Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to force delete resources (#572) #707

Merged
merged 1 commit into from
Jan 18, 2024
Merged

allow to force delete resources (#572) #707

merged 1 commit into from
Jan 18, 2024

Conversation

adietish
Copy link
Collaborator

fixes #572

@adietish adietish self-assigned this Jan 11, 2024
@adietish adietish requested a review from sbouchet January 11, 2024 13:59
@adietish adietish force-pushed the issue-572 branch 3 times, most recently from 64cac17 to 45ae873 Compare January 11, 2024 14:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sbouchet
sbouchet approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. force delete behave like expected, UI shows immediate deletion as expected.

@adietish adietish merged commit e89fbd4 into redhat-developer:main Jan 18, 2024
15 checks passed
@adietish adietish deleted the issue-572 branch January 18, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should allow to force delete resource(s)
2 participants
@adietish @sbouchet